[OpenAL] Fix sourceSeek crash on stopped sources - #27426
Merged
Merged
Conversation
sbc100
changed the title
kripken
reviewed
Jul 28, 2026
kripken
reviewed
Jul 28, 2026
kripken
approved these changes
Jul 28, 2026
Fix a crash in `sourceSeek` when called on a stopped source by resetting `bufsProcessed = 0` before evaluating buffer durations. This replaces emscripten-core#26770. Unlike emscripten-core#26770, which added a top-level check on `src.bufQueue[0]`, this change handles zero/dummy buffers and empty queues safely anywhere in `bufQueue` via `for .. of` iteration and `audioBuf?.duration ?? 0.0`. It also adds assertions to `test_openal_error.c` to verify state correctness after seeking. See: emscripten-core#26770
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash in
sourceSeekwhen called on a stopped source by resettingbufsProcessed = 0before evaluating buffer durations.This replaces #26770. Unlike #26770, which added a top-level check on
src.bufQueue[0], this change handles zero/dummy buffers and empty queues safely anywhere inbufQueueviafor .. ofiteration andaudioBuf?.duration ?? 0.0. It also adds assertions totest_openal_error.cto verify state correctness after seeking.See: #26770